cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From csantanapr <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...
Date Wed, 09 Dec 2015 03:38:19 GMT
Github user csantanapr commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/182#discussion_r47048069
  
    --- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
    @@ -47,8 +47,8 @@ module.exports.prepare = function (cordovaProject) {
             return updateProject(self._config, self.locations);
         })
         .then(function () {
    -        handleIcons(cordovaProject.projectConfig, self.root);
    -        handleSplashScreens(cordovaProject.projectConfig, self.root);
    +        handleIcons(cordovaProject.projectConfig, self.root, self.locations);
    --- End diff --
    
    @eymorale 
    instead of passing self.locations, pass the directory to use
    handleIcons(cordovaProject.projectConfig, self.locations.xcodeCordovaProj);
    handleSplashScreens(cordovaProject.projectConfig, self.locations.xcodeCordovaProj);
    
    then no need to do basename or create new variable originalName



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message