cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <>
Subject [GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...
Date Tue, 08 Dec 2015 07:56:22 GMT
Github user daserge commented on a diff in the pull request:
    --- Diff: server.js ---
    @@ -6,6 +6,11 @@ var formidable = require('formidable'),
     var DIRECT_UPLOAD_LIMIT = 32; // bytes
    +// convert from UTF-8 to ISO-8859-1
    +var LATIN1_SYMBOLS = '¥§©ÆÖÑøøø¼';
    --- End diff --
    The tests 36 and 37 verify the proper handling of a server Latin1 response.
    We could avoid this string constant by changing the tests to pass the symbols in the headers
or params but I'm not sure if it will be retrieved correctly (in terms of encoding) by the
server and whether it will be needed to be converted to Latin1 after that.
    As for the fact that it matches the constant from file-transfer tests - the situation
for maintaining this is the same as for cordova_user/cordova_password - or am I missing something?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message