cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <>
Subject [GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...
Date Mon, 07 Dec 2015 20:23:45 GMT
Github user dblotsky commented on a diff in the pull request:
    --- Diff: server.js ---
    @@ -6,6 +6,11 @@ var formidable = require('formidable'),
     var DIRECT_UPLOAD_LIMIT = 32; // bytes
    +// convert from UTF-8 to ISO-8859-1
    +var LATIN1_SYMBOLS = '¥§©ÆÖÑøøø¼';
    --- End diff --
    This string is copied verbatim in _another repository_, which is very difficult to maintain.
Is there a way to make the test independent of the string that gets passed?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message