cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m-revetria <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...
Date Fri, 04 Dec 2015 14:00:42 GMT
Github user m-revetria commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161974581
  
    I don't think this change completely fix the issue: we should check AVCaptureDevice auth
status just when the picker source is the camera and check ALAssetsLibrary auth status just
when the picker source type is photo library or saved photos album.
    
    Suppose next case:
    1. open the image picker with source type camera
    2. the user doesn't grant access to the device's camera
    3. finally closes the UIImagePickerController by pressing the "Cancel" button. 
    
    In that case the error message "no image selected" is returned, I would spect a message
like "no access to camera".
    
    > Notice that this could happen just the first time the image picker is shown with
source type camera, plugin is checking auth status before presenting the image picker.
    
    You can take a look to full auth check in my commit https://github.com/m-revetria/cordova-plugin-camera/commit/bbdafb08640cafc8e98ed0cbd5d558ad9b6dc150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message