cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...
Date Thu, 03 Dec 2015 22:40:57 GMT
Github user jasongin commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161811902
  
    I agree the file path handling code probably should be centralized in the platform lib
for each platform. But it should be done as part of a broader effort to make all plugin APIs
more consistent in handling files. (My audit supporting that is still in progress.)
    
    I'm OK with adding this bit of duplicated code for now to fix this bug, knowing it may
be refactored later. Also note ideally the contact photo APIs should also support cdvfile://
paths, assuming we don't deprecate cdvfile://. But again I wouldn't block this fix because
of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message