cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...
Date Wed, 02 Dec 2015 00:31:18 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/94#discussion_r46362158
  
    --- Diff: src/android/ContactAccessorSdk5.java ---
    @@ -1631,24 +1631,41 @@ private void insertPhoto(ArrayList<ContentProviderOperation>
ops,
         }
     
         /**
    -       * Get an input stream based on file path or uri content://, http://, file://
    -       *
    -       * @param path
    -       * @return an input stream
    +     * Get an input stream based on file path or uri content://, http://, file://
    +     *
    +     * @param path path to file
    +     * @return an input stream
          * @throws IOException
    -       */
    +     */
         private InputStream getPathFromUri(String path) throws IOException {
    +        String ASSET_PREFIX = "file:///android_asset/";
    --- End diff --
    
    Please set this as a constant at the top, similarly to `EMAIL_REGEXP ` and `MAX_PHOTO_SIZE
`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message