Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F377718414 for ; Wed, 25 Nov 2015 22:46:30 +0000 (UTC) Received: (qmail 81415 invoked by uid 500); 25 Nov 2015 22:46:30 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 81379 invoked by uid 500); 25 Nov 2015 22:46:30 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 81367 invoked by uid 99); 25 Nov 2015 22:46:30 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Nov 2015 22:46:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F101FC7231 for ; Wed, 25 Nov 2015 22:46:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.15 X-Spam-Level: *** X-Spam-Status: No, score=3.15 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id CUHKiuQE1Rbf for ; Wed, 25 Nov 2015 22:46:20 +0000 (UTC) Received: from mail-vk0-f44.google.com (mail-vk0-f44.google.com [209.85.213.44]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 708B620229 for ; Wed, 25 Nov 2015 22:46:19 +0000 (UTC) Received: by vkfr145 with SMTP id r145so44119690vkf.0 for ; Wed, 25 Nov 2015 14:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=xKw9ZFQ1jYiE/FhQ7z2st7g0sb9KORpd3owRX58cWEc=; b=VP9XEcBKmwvDPHskapu7FpM1XRmdWapPGZAQHKbGbzaPe5PEu+IxgLgD2Gsyw1UYoA 1nRXce2DOm92BxUDT4opQQG+Xp1Ze6oXjEBCAP9a/ud/zn+OoX9JH2CWU4Dny4cnelns QEZ1Ivgc2vjtBXjvI3D7HFYgijKGG3gNId2cZhWb6mARajUpPQ8DERPSgyAenARf4YU5 G+mlwSRuASWz3+6z2OUYsDIWEhu98w46NiBvDBZAwvw9k4aEePi4evv0pU8iEAUsHn4B 95PWB7dksmZ38iXSQDOo0Ux7K+HblCWQ6P34djSh6w+atomMdwiwxlvJraOPPVmpRWhK N60w== X-Received: by 10.31.58.74 with SMTP id h71mr36649469vka.151.1448491578307; Wed, 25 Nov 2015 14:46:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.80.2 with HTTP; Wed, 25 Nov 2015 14:45:58 -0800 (PST) In-Reply-To: References: From: Steven Gill Date: Wed, 25 Nov 2015 14:45:58 -0800 Message-ID: Subject: Re: [DISCUSS] Revert Cordova plugins to work with default pinned versions To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=001a114405c6fc3b4205256539ed --001a114405c6fc3b4205256539ed Content-Type: text/plain; charset=UTF-8 haha of course. Well this will give build a chance to add cordova-android 5 support too then :) On Wed, Nov 25, 2015 at 2:41 PM, julio cesar sanchez wrote: > "the user is expected to pin the plugin version", yeah, it's expected, but > I've seen at least 3 questions on the phonegap build forum and one on > stackoverflow related to this, and there are a ton like "My app is failing > now, I built it x time ago and it worked, I didn't change anything, so you > broke it" because people don't pin the cli and the plugins > > 2015-11-25 23:28 GMT+01:00 Steven Gill : > > > having trouble rolling latest back currently. npm seems to be having > issues > > with dist-tag. https://github.com/npm/npm/issues/10548 > > > > I'll revert as soon as I can. I've already pinged people at npm. > > > > On Wed, Nov 25, 2015 at 2:26 PM, Parashuram N > > wrote: > > > > > +1 to having a way for pinning too. > > > > > > -----Original Message----- > > > From: Shazron [mailto:shazron@gmail.com] > > > Sent: Wednesday, November 25, 2015 2:23 PM > > > To: dev@cordova.apache.org > > > Subject: Re: [DISCUSS] Revert Cordova plugins to work with default > pinned > > > versions > > > > > > +1 what Steve said. Let's make sure all stakeholders take note of the > > > discuss threads for plugins, not just platforms, in the future so we > can > > > nip this in the bud. > > > > > > "Cordova should not be backtracking releases due to downstreams" -> > > > Steve's cli pinning proposal would solve the VS scenario in the future, > > > would it not? > > > > > > On Wed, Nov 25, 2015 at 2:06 PM, julio cesar sanchez < > > > jcesarmobile@gmail.com> wrote: > > > > This has hit phonegap build users too as cordova android 5 isn't > > > > released there yet and people doesn't pin the plugin version > > > > > > > > 2015-11-25 22:38 GMT+01:00 Parashuram N : > > > > > > > >> I agree that we should have brought this up during the DISCUSS > phase. > > > >> > > > >> VS is preparing for a fix in the week of Dec 7 when we are > > > >> anticipating Cordova 6 with ios9 and marshmallow support. > > > >> > > > >> -----Original Message----- > > > >> From: Steven Gill [mailto:stevengill97@gmail.com] > > > >> Sent: Wednesday, November 25, 2015 12:46 PM > > > >> To: dev@cordova.apache.org > > > >> Subject: Re: [DISCUSS] Revert Cordova plugins to work with default > > > >> pinned versions > > > >> > > > >> I think it is more reasonable to get users to explicitly update > their > > > >> cordova-android to 5 than it is to get people who are using > > > >> cordova-android@5 now to be explicit about adding plugins versions > > > >> which are higher than what npm shows (assuming we set latest back to > > > >> previous release). > > > >> > > > >> Most people want to and should be supporting marshmallow. > > > >> > > > >> In the case you describe above about installing the camera plugin > and > > > >> it failing, it isn't a silent failure. Users get notified that the > > > >> version of camera doesn't support their version of android and they > > > should update. > > > >> Users using cordova-android 5 don't get such a nice failure message > > > >> for using older plugins that don't support the new permission model. > > > >> Instead they realize at runtime. Much worse. > > > >> > > > >> Now, the reason why I am willing to revert the `latest` tag for > those > > > >> 5 plugins (file, media, camera, contacts, geolocation) to previous > > > >> releases is the case you brought up in slack. Visual studio grabs > > > >> latest plugins and can't get a update out quickly. We can revert > > > >> those until we get cordova@6 out. > > > >> > > > >> I think this is more an issue with VS and less with cordova. Cordova > > > >> should not be backtracking releases due to downstreams. The discuss > > > >> thread for plugins came out 19 days ago. We have been chatting about > > > >> this release for even longer than that! > > > >> > > > >> If we do this, I want to be very clear that it is a special > exception. > > > >> Cordova should not be doing this again. It is up to Visual studio to > > > >> be prepared for releases. It is not cordova's responsibility. > > > >> > > > >> With pinning plugins landing in cordova@6, this hopefully won't be > an > > > >> issue anymore. I hope to get cordova@6 out in a couple of weeks. At > > > >> that time, latest will once again be switched for those 5 plugins. > VS > > > >> and other downstream, please be prepared for it. > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> Hi, > > > >> > > > >> The latest Cordova plugin release [1] has some plugins like camera, > > > >> contacts, files, geolocation, etc. that require mailto: > > > >> cordova-android@5.0.0 to work. The latest released version of > > > >> Cordova-cli does not pin mailto: > > > >> cordova-android@5.0.0, but instead pins cordova-android@4.1.1. > > > >> > > > >> Scenario > > > >> - User adds android platform using cordova platform add android - he > > > >> gets > > > >> cordova-anrdoid@4.1.1 > > > >> - User now adds the camera plugin - cordova plugin add camera - gets > > > >> the version of the camera plugin that works only with > > > >> cordova-android@5.0 > > > >> > > > >> This combination does not work and the scenario breaks. > > > >> > > > >> I do understand that there are many folks who are already using > > > >> cordova-android@5 for marshmallow support, and that we need to > > > >> release the versions of plugins that support marshmallow. However, > > > >> these folks already add the cordova-android@5.0 platform by > > > >> explicitly specifying a version number. Hence, it would be > reasonable > > > >> to expect them to also add the supported plugins by specifying a > > > version number. > > > >> For folks who still add platforms and plugins without specifying > > > >> version numbers, I think we should ensure that the scenario > continues > > > to work. > > > >> > > > >> > > > >> Fix > > > >> I think the way to fix this issue would be to still have the > verisons > > > >> of plugins that support cordova-android@5.0 released, but the > > "latest" > > > >> should point to the versions that cordova-cli has pinned. > > > >> > > > >> [1] > > > >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcord > > > >> ova.apache.org > %2fnews%2f2015%2f11%2f24%2fplugins-release.html&data=01 > > > >> %7c01%7cpanarasi%40microsoft.com > %7c85b4ca37be3146007dc608d2f5d96bb3%7 > > > >> > c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=r5p4htJsu3KVVOIl1rofr9IPJ > > > >> 5bASs6iubW8Md%2bb2hM%3d > > > >> > > > >> > --------------------------------------------------------------------- > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > > > >> For additional commands, e-mail: dev-help@cordova.apache.org > > > >> > > > >> > --------------------------------------------------------------------- > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > > > >> For additional commands, e-mail: dev-help@cordova.apache.org > > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > > > For additional commands, e-mail: dev-help@cordova.apache.org > > > > > > > > > --001a114405c6fc3b4205256539ed--