Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BB4E18F01 for ; Mon, 2 Nov 2015 04:03:14 +0000 (UTC) Received: (qmail 33866 invoked by uid 500); 2 Nov 2015 04:03:14 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 33831 invoked by uid 500); 2 Nov 2015 04:03:14 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 33819 invoked by uid 99); 2 Nov 2015 04:03:13 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 04:03:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2F58D180974 for ; Mon, 2 Nov 2015 04:03:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.88 X-Spam-Level: ** X-Spam-Status: No, score=2.88 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EieWXqzfk5JQ for ; Mon, 2 Nov 2015 04:03:04 +0000 (UTC) Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id CA90220ED2 for ; Mon, 2 Nov 2015 04:03:03 +0000 (UTC) Received: by obctp1 with SMTP id tp1so85075721obc.2 for ; Sun, 01 Nov 2015 20:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=FsQivakl1n2x4CwGllWQZ1LjsN1u/kqyVpfqjTFmtY8=; b=JAGCattAz/DTIQssntbmCLwbRttHKVY+U0OrqDAgMHUMmSS/U/coHizEOpVlBuI+m/ Gvwmm/JnZ/wPLCyZqlgcYVR0U9+8s8gjebvszQYEjIcV17Zho57VT1APTVrOxMesq83N rZVr/SLBmn9zTmIKF0vnIvLMxmwYCuCGr9UaT42M153GoTbjyF1nqXVmRv+M+ZWG3Fq/ bnQ/2F5DRMpizRyVuiRh2ulL7tHSSVCMrET5QOOmNLd0JJsms5f3oUoG/SAzzn/5Ti/d oQ4s75oBUX6fIOz4+Te5M1ISJMMtiUJOI/DrVEnP0xzgvEmD1Oh+ZsSTPH4QIPAix6PP GRxw== MIME-Version: 1.0 X-Received: by 10.182.22.229 with SMTP id h5mr13638029obf.26.1446436977357; Sun, 01 Nov 2015 20:02:57 -0800 (PST) Received: by 10.76.91.137 with HTTP; Sun, 1 Nov 2015 20:02:57 -0800 (PST) In-Reply-To: <20151031201507.55C3CDFC77@git1-us-west.apache.org> References: <20151031201507.55C3CDFC77@git1-us-west.apache.org> Date: Sun, 1 Nov 2015 20:02:57 -0800 Message-ID: Subject: Re: [GitHub] cordova-plugin-file pull request: CB-7253: requestFileSystem fails... From: Jesse To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=001a11c2ef1039ba7d052386da73 --001a11c2ef1039ba7d052386da73 Content-Type: text/plain; charset=UTF-8 I thought the whole KiB thing was a geek joke. I had no idea it even existed until I saw all of the text related to image resources allowed for submitting apps to the showcase. ( Which I also thought was an entirely tongue in cheek request ... ) @purplecabbage risingj.com On Sat, Oct 31, 2015 at 1:15 PM, dblotsky wrote: > Github user dblotsky commented on a diff in the pull request: > > > https://github.com/apache/cordova-plugin-file/pull/145#discussion_r43575761 > > --- Diff: src/android/DirectoryManager.java --- > @@ -56,45 +56,46 @@ public static boolean testFileExists(String name) { > } > > /** > - * Get the free disk space > - * > + * Get the free space in external storage > + * > * @return Size in KB or -1 if not available > --- End diff -- > > Hah, I actually didn't know that the tradition has been for KB to mean > 1024. I had someone drill KiB into me recently, so I was under the > impression that KiB were the way to go. Thanks for disillusioning me! > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastructure@apache.org or file a JIRA ticket > with INFRA. > --- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org > For additional commands, e-mail: dev-help@cordova.apache.org > > --001a11c2ef1039ba7d052386da73--