Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: dblotsky <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-118-cordova-plugin-file-transfer@git.apache.org>
In-Reply-To: <git-pr-118-cordova-plugin-file-transfer@git.apache.org>
Subject: [GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some
 file-trans...
Content-Type: text/plain
Message-Id: <20151125225514.7B56EE17F8@git1-us-west.apache.org>
Date: Wed, 25 Nov 2015 22:55:14 +0000 (UTC)

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928589
  
    --- Diff: tests/tests.js ---
    @@ -468,6 +468,8 @@ exports.defineAutoTests = function () {
                     it("filetransfer.spec.10 should be stopped by abort() right away", function (done) {
     
                         var fileURL = 'http://cordova.apache.org/downloads/BlueZedEx.mp3';
    +                    // Some Windows Phone 8.1 devices need ~1-2 sec to create an upload operation.
    +                    var graceTimeout = isWindows ? GRACE_TIME_DELTA * 6 : GRACE_TIME_DELTA;
    --- End diff --
    
    This might be best set at the top of the file, along with the other constants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org