Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7793C1769E for ; Mon, 2 Nov 2015 07:59:40 +0000 (UTC) Received: (qmail 44550 invoked by uid 500); 2 Nov 2015 07:59:40 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 44507 invoked by uid 500); 2 Nov 2015 07:59:40 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 44496 invoked by uid 99); 2 Nov 2015 07:59:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 07:59:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BBD00DFBDE; Mon, 2 Nov 2015 07:59:39 +0000 (UTC) From: daserge To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-file-transfer pull request: Added support for PATCH... Content-Type: text/plain Message-Id: <20151102075939.BBD00DFBDE@git1-us-west.apache.org> Date: Mon, 2 Nov 2015 07:59:39 +0000 (UTC) Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/86#issuecomment-152946117 @alvaromb, thanks for your contribution! Please sign the ICLA so that this code could be merged in:http://www.apache.org/dev/new-committers-guide.html#cla Added a Jira issue: [CB-9928 Add support for PATCH request uploads](https://issues.apache.org/jira/browse/CB-9928). Please rename the PR and commit message to match the Jira title (to be `CB-9928 ` prefixed at least) to enable Jira + Github integration hooks. Consider adding a test case to [client](https://github.com/apache/cordova-plugin-file-transfer/blob/4dc697a8636bc0541b2fe99f136ce9aa39cbe970/tests/tests.js#L659) and [server](https://github.com/apache/cordova-labs/blob/dafe2863c0ffbec670e27000b8630d7cf6d870e5/server.js#L37). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org