cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: CB-10017: Restored broken image in amaz...
Date Mon, 16 Nov 2015 23:15:22 GMT
GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-docs/pull/422

    CB-10017: Restored broken image in amazon fireos docs

    This restores a broken image link that was deleted as part of f90b9d66056349aa33480675f013ae9269823d8d.
Clearly, this is a big problem with how we handle images. Images need to be pinned with versions,
otherwise if an image is deleted in master then the link will be broken in all of the past
docs (hopefully we can come up with a smart way of handling this that does not require us
to have 50 copies of every image). We should probably do a sweep to see if there are any other
missing images in the past docs. Also, the linked commit makes it seem like this image isn't
currently correct for Amazon fireos.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/riknoll/cordova-docs fireos-broken-image

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #422
    
----
commit 479757056c102da254d0329662fd380f65aa1449
Author: riknoll <richard.b.knoll@gmail.com>
Date:   2015-11-16T23:07:51Z

    CB-10017: Restored broken image in amazon fireos docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message