cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akubera <...@git.apache.org>
Subject [GitHub] cordova-osx pull request: Fix prompt submission bug
Date Sun, 29 Nov 2015 04:44:50 GMT
GitHub user akubera opened a pull request:

    https://github.com/apache/cordova-osx/pull/27

    Fix prompt submission bug

    Fixes an issue where clicking "OK" in a pop-up prompt does not return any value (despite
being entered). The previous button-value checked was the constant NSAlertDefaultReturn, but
since the NSAlert was created with the 'init' constructor, the runModal method will return
one of NSAlert{first,second,third}ButtonReturn constants.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akubera/cordova-osx patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-osx/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit fde613a2b51e81b07b7d12fc9be496e51efb2fef
Author: Andrew <andrewkubera@gmail.com>
Date:   2015-11-24T01:06:19Z

    Fix prompt submission bug
    
    Fixes an issue where clicking "OK" in a pop-up prompt does not return any value (despite
being entered). The previous button-value checked was the constant NSAlertDefaultReturn, but
since the NSAlert was created with the 'init' constructor, the runModal method will return
one of NSAlert{first,second,third}ButtonReturn constants.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message