cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-9169 android: Fixed filetyp...
Date Tue, 10 Nov 2015 20:06:36 GMT
GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/136

    CB-9169 android: Fixed filetype for uncompressed images and added quirk

    When trying to get uncompressed images on Android using camera options like these:
    ``` javascript
    {
        destinationType : Camera.DestinationType.FILE_URL,
        sourceType : Camera.PictureSourceType.CAMERA,
        encodingType: Camera.EncodingType.PNG,
        quality: 100,
        saveToPhotoAlbum: true
    }
    ```
    the plugin will return a JPEG file with a .png filename. This pull request fixes the filename
and documents the Android quirk that `encodingType` is ignored by the plugin on Android for
uncompressed files. It currently does not make sense to actually provide PNG support in this
case, because native camera apps return JPEG files and so converting to PNG does not improve
quality, it just hurts performance. Same can be said for the gallery which just returns the
selected file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-9169

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit 891b4a2d089c9deb2e4788dd5c12dff7267d38cc
Author: riknoll <richard.b.knoll@gmail.com>
Date:   2015-11-10T19:50:42Z

    CB-9169 android: Fixed filetype for uncompressed images and added quirk

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message