cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alexbuijs <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Fix syntax error when br...
Date Wed, 25 Nov 2015 14:13:37 GMT
GitHub user alexbuijs opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/127

    Fix syntax error when browserifying

    When browserifying this plugin, aliasify throws an error:
    ```
    events.js:141
          throw er; // Unhandled 'error' event
          ^
    
    SyntaxError: 'return' outside of function (25:4) (while aliasify was processing plugins/cordova-plugin-inappbrowser/www/inappbrowser.js)
while parsing file: plugins/cordova-plugin-inappbrowser/www/inappbrowser.js
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alexbuijs/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 14f8e0e8c93bb57c22c39b575048effe9ac21041
Author: Alex Buijs <contact@alexbuijsweb.nl>
Date:   2015-11-25T14:04:56Z

    Fix syntax error when browserifying
    
    When browserifying this plugin, aliasify throws an error:
    ```
    events.js:141
          throw er; // Unhandled 'error' event
          ^
    
    SyntaxError: 'return' outside of function (25:4) (while aliasify was processing plugins/cordova-plugin-inappbrowser/www/inappbrowser.js)
while parsing file: plugins/cordova-plugin-inappbrowser/www/inappbrowser.js
    ```

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message