cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: [DISCUSS] Removal of unused iOS bridges
Date Thu, 05 Nov 2015 19:03:46 GMT
I will integrate this later today.

On Wed, Nov 4, 2015 at 2:18 PM, Carlos Santana <csantana23@gmail.com> wrote:
> LGTM left a question.
>
> On Tue, Nov 3, 2015 at 6:36 PM Shazron <shazron@gmail.com> wrote:
>
>> Sent a PR https://github.com/apache/cordova-ios/pull/178 please
>> review/comment etc
>>
>> On Thu, Oct 29, 2015 at 7:27 AM, julio cesar sanchez
>> <jcesarmobile@gmail.com> wrote:
>> > +1, I first saw the bridges when looking into one issue but didn't know
>> if
>> > the user configures them or if it was something internal that changed on
>> > certain circumstances, so if it isn't used, remove it.
>> >
>> >
>> > 2015-10-29 3:35 GMT+01:00 Carlos Santana <csantana23@gmail.com>:
>> >
>> >> Sorry late to the bridge dead sentence.
>> >>
>> >> +1 Strongly agree, some of these feel like old hacks that are not need
>> it
>> >> anymore, and also not public documented so it's OK for removal.
>> >>
>> >>
>> >>
>> >> On Tue, Oct 27, 2015 at 9:06 PM Tommy Williams <tommy@devgeeks.org>
>> wrote:
>> >>
>> >> > +1
>> >> >
>> >> >
>> >> > On 28 October 2015 at 11:45:00, Simon MacDonald (
>> >> simon.macdonald@gmail.com)
>> >> > wrote:
>> >> >
>> >> > +1
>> >> >
>> >> > Simon Mac Donald
>> >> > http://hi.im/simonmacdonald
>> >> >
>> >> >
>> >> > On Tue, Oct 27, 2015 at 8:13 PM, Tim Barham <Tim.Barham@microsoft.com
>> >
>> >> > wrote:
>> >> > > +1
>> >> > >
>> >> > > -----Original Message-----
>> >> > > From: Steven Gill [mailto:stevengill97@gmail.com]
>> >> > > Sent: Tuesday, October 27, 2015 5:11 PM
>> >> > > To: dev@cordova.apache.org
>> >> > > Subject: Re: [DISCUSS] Removal of unused iOS bridges
>> >> > >
>> >> > > +1
>> >> > >
>> >> > > On Tue, Oct 27, 2015 at 5:05 PM, Shazron <shazron@gmail.com>
wrote:
>> >> > >
>> >> > >> Filed
>> >> > >>
>> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
>> >> > >> s.apache.org
>> >> %2fjira%2fbrowse%2fCB-9883&data=01%7c01%7cTBARHAM%40064d.m
>> >> > >> gd.microsoft.com
>> >> %7cfcf3db870c2d4d8b63ac08d2df2c6078%7c72f988bf86f141af
>> >> > >>
>> 91ab2d7cd011db47%7c1&sdata=GRbmnhveNymzREsn6T4SzKSTSSBtcqijfXhFAEMejNA
>> >> > >> %3d
>> >> > >>
>> >> > >> On Tue, Oct 27, 2015 at 5:00 PM, Shazron <shazron@gmail.com>
>> wrote:
>> >> > >> > ## DESCRIPTION
>> >> > >> >
>> >> > >> > We have 7 bridges in iOS:
>> >> > >> >
>> >> > >>
>> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
>> >> > >> b.com
>> >> %2fapache%2fcordova-ios%2fblob%2fc0fe92d6c0b91efa2da0d5cec78e0baa
>> >> > >>
>> 95ce55c9%2fcordova-js-src%2fexec.js%23L36-L43&data=01%7c01%7cTBARHAM%4
>> >> > >> 0064d.mgd.microsoft.com
>> >> %7cfcf3db870c2d4d8b63ac08d2df2c6078%7c72f988bf8
>> >> > >>
>> 6f141af91ab2d7cd011db47%7c1&sdata=MTwKRVfHlU4fHHI7c8Pa9vEqYELxmJudMWkl
>> >> > >> ILrvqAc%3d
>> >> > >> >
>> >> > >> > IFRAME_NAV is the default, and is actively used.
>> >> > >> > WK_WEBVIEW_BINDING will be used by the wkwebview-engine
plugin,
>> >> > >> > although I really want the plugin itself to inject this,
haven't
>> >> > >> > explored that yet.
>> >> > >> >
>> >> > >> > ## PROPOSAL
>> >> > >> >
>> >> > >> > Remove these bridges:
>> >> > >> >
>> >> > >>
>> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
>> >> > >> b.com
>> >> %2fapache%2fcordova-ios%2fblob%2fc0fe92d6c0b91efa2da0d5cec78e0baa
>> >> > >>
>> 95ce55c9%2fcordova-js-src%2fexec.js%23L38-L42&data=01%7c01%7cTBARHAM%4
>> >> > >> 0064d.mgd.microsoft.com
>> >> %7cfcf3db870c2d4d8b63ac08d2df2c6078%7c72f988bf8
>> >> > >>
>> 6f141af91ab2d7cd011db47%7c1&sdata=M70lyqlz4itP87I1XA%2bSwDpcCu7cfsI%2f
>> >> > >> DzjBf63QcAo%3d
>> >> > >> >
>> >> > >> > XHR_NO_PAYLOAD
>> >> > >> > XHR_WITH_PAYLOAD
>> >> > >> > XHR_OPTIONAL_PAYLOAD
>> >> > >> > IFRAME_HASH_NO_PAYLOAD
>> >> > >> > IFRAME_HASH_WITH_PAYLOAD
>> >> > >> >
>> >> > >> > ... and their associated native code.
>> >> > >>
>> >> > >>
>> ---------------------------------------------------------------------
>> >> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> >> > >> For additional commands, e-mail: dev-help@cordova.apache.org
>> >> > >>
>> >> > >>
>> >> > >
>> >> > >
>> ---------------------------------------------------------------------
>> >> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> >> > > For additional commands, e-mail: dev-help@cordova.apache.org
>> >> >
>> >> > ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> >> > For additional commands, e-mail: dev-help@cordova.apache.org
>> >> >
>> >> >
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message