cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-6979 Don't create duplica...
Date Fri, 27 Nov 2015 10:08:02 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/89#discussion_r46032879
  
    --- Diff: src/ios/CDVContact.m ---
    @@ -1324,6 +1324,7 @@ - (NSObject*)extractPhotos
         NSMutableArray* photos = nil;
     
         if (ABPersonHasImageData(self.record)) {
    +        CFIndex photoId = ABRecordGetRecordID(self.record);
    --- End diff --
    
    Yes. It can also return `-1` when pemission to address book is denied, but this is hardly
ever possible in our case, since we now asking for permissions always (since https://github.com/apache/cordova-plugin-contacts/commit/617fb764bf1c7047cfe02cf346771dd7fa38ed40)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message