cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-5308 Return rawId instead...
Date Fri, 27 Nov 2015 07:49:21 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023669
  
    --- Diff: tests/tests.js ---
    @@ -37,23 +37,34 @@ exports.defineAutoTests = function() {
     
         var MEDIUM_TIMEOUT = 30000;
     
    -    var removeContact = function() {
    -            if (gContactObj) {
    -                gContactObj.remove(function() {}, function() {
    -                    console.log("[CONTACTS ERROR]: removeContact cleanup method failed
to clean up test artifacts.");
    -                });
    -                gContactObj = null;
    -            }
    -        };
    +    var removeContact = function(done) {
    +        if (!done) {
    +            done = function noop () { };
    --- End diff --
    
    I just realized that `removeContact` is now used only in async way (with `done`) so this
is not needed at all. Removing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message