cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...
Date Wed, 25 Nov 2015 22:52:30 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928408
  
    --- Diff: src/windows/FileTransferProxy.js ---
    @@ -116,9 +118,13 @@ exec(win, fail, 'FileTransfer', 'upload',
     
                 // check if download isn't already cancelled
                 var uploadOp = fileTransferOps[uploadId];
    -            if (uploadOp && uploadOp.state === FileTransferOperation.CANCELLED)
{
    +            if (uploadOp && uploadOp.state === FileTransferOperation.CANCELLED
|| abortedOpIds.indexOf(uploadId) !== -1) {
    --- End diff --
    
    This condition is hard to read. Please encapsulate this logic in a descriptive function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message