cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
Date Mon, 23 Nov 2015 18:10:58 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637931
  
    --- Diff: src/windows/ContactProxy.js ---
    @@ -242,7 +242,9 @@ module.exports = {
             pickRequest.done(function (contact) {
                 // if contact was not picked
                 if (!contact) {
    -                fail && fail(new Error("User did not pick a contact."));
    --- End diff --
    
    This looks good.  The implied check for `fail != null` here was unnecessary as ALL calls
to exec proxies have valid success/error function passed in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message