cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...
Date Fri, 20 Nov 2015 09:12:47 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158332458
  
    Also the test should be extended to verify the data received by [the server](https://github.com/apache/cordova-labs/blob/0987a423d8ba82901a39caf9d1c013f06192e83d/server.js#L37)
- it echoes the received file params back so at least we can verify the file length now (see
[verifyUpload function](https://github.com/apache/cordova-plugin-file-transfer/blob/97031b2d7528033c82bdff4659b9041dd9512a51/tests/tests.js#L696))
and we should also verify the contents IMO.
    
    The server responds back like this now:
    ```
    {"fields":{},"files":{"file":{"size":17,"path":"C:\\Users\\SERGEY~1.SHA\\AppData\\Local\\Temp\\upload_d2fac85e424cb5bda30b5cb5900978f7","name":"fileToUpload.txt","type":null,"mtime":"2015-11-19T16:38:41.038Z"}}}
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message