cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From convey-mane <>
Subject [GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...
Date Mon, 16 Nov 2015 10:49:31 GMT
Github user convey-mane commented on the pull request:
    > in general we try to be extra careful when we add platform-specific options to plugins
    another reason, we did this pull request, is that on Android and WinMobile (at least)
it already _is_ possible to crop with a flexible rectangle (OK, Android is a little, well,
funny, we know) – so on iOS it's _platform-specific **missing**_ up to now, isn't it :wink:.
    Regarding your [first answer](,
I don't know if I understand you fully:
    when you say
    > this should be left to a third party plugin since this pull isn't replacing the native
crop and is based off an external library already
    > I wonder if we should even be encouraging people to use allowEdit as opposed to other
options (i.e. third party plugins)
    do you mean, that cropping should be generally left out of your standard camera plugin?
And that a fork like our's be that "third party plugin"?
    Isn't that more cumbersome for that third party and for those who want to use it? (when
it comes to merging things from your original plugin)?
    - _Not_ replacing the native crop was intentionally, so to not alter the way the plugin
was used up to now.
    - Concerning the fact that it's based off an external library: the mentioned library contains
much more, than is used here; there are three (or four?) ways to do a crop, only the one with
the flexible rectangle is used here, everything else, which is useless here, I "simply" stripped
out, when using it the first time in our "old" native App. Meaning: I didn't do a fork, didn't
contribute to the original, or something similar.
    OK, everything else maybe better in the discussion thread (just rounding down the comments

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message