cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <>
Subject [GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...
Date Fri, 13 Nov 2015 15:00:01 GMT
Github user daserge commented on the pull request:
    @convey-mane, I believe you should do the following with the PR:
    - Send a message to the [dev-list]( with the feature
proposal for discussion ([here is an example of such a thread](,
    - If the vote is positive, then create a new issue on and assign
the id you get to this pull request, so it's linked and tracked. Example: PR and commits title
`CB-9999 iOS: new resizable cropping rectangle instead of Apple's standard square` (this enables
Jira&Github integration and issue tracking),
    - Squash commits into one or two (f.e. split dependency library into a separate commit),
    - Rebase the PR to master to avoid merge conflicts.
    You can force-push into your branch to remove unnecessary/old commits (off course don't
forget to back-up your work).
    IMO it is better to use rebase vs merge in terms of history readability.
    Useful link:

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message