cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From convey-mane <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...
Date Thu, 12 Nov 2015 14:36:01 GMT
Github user convey-mane commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156117731
  
    @jcesarmobile when you write "_we should discuss_" … do you mean you "Apaches"?
    Or should I participate? Stand up for my commits, argue for them?
    
    Yes, it maybe is big, but it's no "change" imho, it _adds_ functionality, that doesn't
_change_ the behavior of the plugin, as it was before my commits, as long as you don't use
"my" new preference (and without that, I don't think you run the risk of being rejected by
Apple).
    
    Is it a "quirk"? Well, _afaik_ that notification I use is not documented (somewhere on
[stackoverflow](http://stackoverflow.com/questions/31053407/is-uiimagepickercontrolleruserdidcaptureitem-is-private-api-of-uiimagepickercon?s=2|1.6652)
it's mentioned, it would be "private"); but – as I also found this solution  on [stackoverflow](http://stackoverflow.com/q/17942444)
(if I remember right) – it wasn't my original idea, of course – there's also mention about
an App that was [successfully submitted](http://stackoverflow.com/questions/17942444/uiimagepicker-cameraoverlayview-appears-on-retake-screen#comment50178373_17973384).
    And that is obviously the notification Apple themselves use to get along with the camera;
if in the future they change that behavior, we'll have to see; that also can happen with documented
notifications, doesn't it? Maybe then they also offer a comfortable way, that eliminates the
need for my "quirk".
    
    The second part of that "quirk", where I have to dismiss the camera _premature_ – well,
why not? I don't _kill_ it, it's still closed with the regular `dismissViewControllerAnimated`,
still within the delegate method `didFinishPickingMediaWithInfo`, where it's also closed in
the "normal" behavior, when the user crops the picture with the standard square crop and taps
"Use Photo". `didFinishPickingMediaWithInfo` is just explicitly called earlier when that "undocumented"
`_UIImagePickerControllerUserDidCaptureItem` is catched (and the picture is dug out explicitly)
– before the camera is able to present the square crop.
    
    If Apple refuses to offer an option to avoid that often useless "Use Photo"-dialog –
if you, on the other hand, _do_ want to use the standard camera-UI (it's beautiful with that
transparent toolbar and big round trigger-button, offers useful standard features like flash
and switch cameras)?
    I mean, with our "old" native App (which should be replaced by a cordova-App) I did implement
an overlay of my own, not knowing about this "quirk" then (there was also the need for an
extra toolbar button, so I went that way anyway), but it was considerably more work and doesn't
look as good …
    
    If you will reject … we _really do need_ the feature of a flexible, resizable cropping
rectangle. We can't imagine, that no one else could use and want that, too.
    I implemented it parametrizable, just because we want that to go into the official repository;
otherwise it will be some act, every time there's some commit, we also would like to get …


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message