cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <>
Subject [GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...
Date Wed, 11 Nov 2015 17:53:55 GMT
Github user jasongin commented on a diff in the pull request:
    --- Diff: framework/src/org/apache/cordova/ ---
    @@ -115,6 +115,10 @@ public boolean onActivityResult(int requestCode, int resultCode,
Intent intent)
                 savedResult = new ActivityResultHolder(requestCode, resultCode, intent);
                 if (pluginManager != null) {
                     callback = pluginManager.getPlugin(initCallbackService);
    +                if(callback != null) {
    +                    callback.onRestoreStateForActivityResult(savedPluginState.getBundle(callback.getServiceName()),
    --- End diff --
    Are you sure savedPluginState will always be non-null at this point? And that it will
have the expected bundle?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message