cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <>
Subject [GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...
Date Wed, 11 Nov 2015 17:49:33 GMT
Github user jasongin commented on a diff in the pull request:
    --- Diff: framework/src/org/apache/cordova/ ---
    @@ -147,6 +151,8 @@ public void onSaveInstanceState(Bundle outState) {
                 String serviceName = activityResultCallback.getServiceName();
                 outState.putString("callbackService", serviceName);
    +        outState.putBundle("plugin", pluginManager.onSaveInstanceState());
    --- End diff --
    Do you need to check if pluginManager is not null? I ask because there is a check for
that on line 116.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message