cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From csantanapr <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request: Fixes CB-4712, CB-5439 stat...
Date Sat, 07 Nov 2015 01:46:51 GMT
Github user csantanapr commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/38#issuecomment-154596695
  
    LGTM, rebase the two commits into a single one.
    Basically you added an observer that anytime that you get notify about status bar change,
you do a resize. The approach sounds reasonable.
    It will be good if @shazron can take a quick look also.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message