cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: feature CB-8777 Add option onl...
Date Fri, 06 Nov 2015 19:57:40 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/80#discussion_r44180556
  
    --- Diff: src/android/CameraLauncher.java ---
    @@ -270,18 +279,20 @@ public void getImage(int srcType, int returnType, int encodingType)
{
             croppedUri = null;
             if (this.mediaType == PICTURE) {
                 intent.setType("image/*");
    -            if (this.allowEdit) {
    +            if (this.onlyGalleries) {
    --- End diff --
    
    Shouldn't `allowEdit` be kept separate from this feature? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message