cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Date Fri, 06 Nov 2015 05:52:44 GMT
Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44106504
  
    --- Diff: src/android/ContentFilesystem.java ---
    @@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one
      */
     package org.apache.cordova.file;
     
    -import java.io.File;
    -import java.io.FileNotFoundException;
    -import java.io.IOException;
    -import java.io.OutputStream;
    -
    -import org.apache.cordova.CordovaResourceApi;
    -import org.json.JSONArray;
    -import org.json.JSONException;
    -import org.json.JSONObject;
    -
     import android.content.ContentResolver;
     import android.content.Context;
     import android.database.Cursor;
     import android.net.Uri;
    +import android.provider.DocumentsContract;
     import android.provider.MediaStore;
     import android.provider.OpenableColumns;
    +import java.io.File;
    +import java.io.FileNotFoundException;
    +import java.io.IOException;
    +import org.apache.cordova.CordovaResourceApi;
    +import org.json.JSONException;
    +import org.json.JSONObject;
    --- End diff --
    
    LULZ! They follow the "Android Studio/Eclipse put it there for me style".
    
    Seriously, Cordova, Android and Java imports should be grouped separately, but I'm not
completely concerned about the order of the groupings. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message