cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Date Thu, 05 Nov 2015 23:15:56 GMT
Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44084198
  
    --- Diff: src/android/ContentFilesystem.java ---
    @@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one
      */
     package org.apache.cordova.file;
     
    -import java.io.File;
    -import java.io.FileNotFoundException;
    -import java.io.IOException;
    -import java.io.OutputStream;
    -
    -import org.apache.cordova.CordovaResourceApi;
    -import org.json.JSONArray;
    -import org.json.JSONException;
    -import org.json.JSONObject;
    -
     import android.content.ContentResolver;
     import android.content.Context;
     import android.database.Cursor;
     import android.net.Uri;
    +import android.provider.DocumentsContract;
     import android.provider.MediaStore;
     import android.provider.OpenableColumns;
    +import java.io.File;
    +import java.io.FileNotFoundException;
    +import java.io.IOException;
    +import org.apache.cordova.CordovaResourceApi;
    +import org.json.JSONException;
    +import org.json.JSONObject;
    --- End diff --
    
    Please keep the import statements separated into groups. Ideally I think they should follow
the [Android style](http://source.android.com/source/code-style.html#order-import-statements),
but not all of Cordova's Android code follows that now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message