cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-7253: requestFileSystem fails...
Date Tue, 03 Nov 2015 21:57:48 GMT
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/145#issuecomment-153502297
  
    LGTM. I don't really know how to test this thoroughly because of the external storage
stuff, but the code looks solid and mobilespec passes (on a marshmallow device and 5.1.1 emulator)
so I will merge this in by the end of today unless there are any objections.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message