Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <249664a9c0ed45069f945a7b28c69573@SINPR30MB0057.064d.mgd.msft.net>
References: <249664a9c0ed45069f945a7b28c69573@SINPR30MB0057.064d.mgd.msft.net>
From: Shazron <shazron@gmail.com>
Date: Fri, 2 Oct 2015 12:04:23 -0700
Message-ID: 
 <CAE6O_-bQCyOdnpRZo7o9rPtVVTyt8GAttWxMFwFPmd0jP2OOMA@mail.gmail.com>
Subject: Re: Question about ios non-custom frameworks
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

+1

On Fri, Oct 2, 2015 at 8:14 AM, Vladimir Kotikov (Akvelon)
<v-vlkoti@microsoft.com> wrote:
> The previous email was broken due to Ctrl+Enter, sorry =E2=98=B9
>
> I=E2=80=99m looking into the tests failures on OS X, caused by PlatformAp=
i refactoring and it seems they caused by double caching of ios pbxproj fil=
es: first time in ios_parser [1] and second time in PlatformMunger (through=
 ConfigKeeper class) [2], [3]. It seems that at some time one file get cach=
ed twice and then saving one cached instance we=E2=80=99re overwriting chan=
ges, saved from another cache.
>
> So I have a question: What is the idea of dealing with xcode files and, i=
n particular , with non-custom frameworks in PlatformMunger instead of ios =
plugin handler, along with custom frameworks. The one reason I see is that =
we need to count references to these frameworks, so if two or more plugins =
references same frameworks, removal of one of them won=E2=80=99t remove fra=
mework reference from pbxproj file.
>
> However, if this this is the only reason, would it make sense to move non=
-custom frameworks related logic  to plugin handler? This will resolve thos=
e caching issues and looks more intuitive and easier to maintain for me.
>
> I=E2=80=99ve made some prototype work on this refactoring and it seems to=
 work fine. See this commit for details: [4]
>
> -----
> [1] https://github.com/MSOpenTech/cordova-lib/blob/master/cordova-lib/src=
/plugman/platforms/ios.js#L210
> [2] https://github.com/MSOpenTech/cordova-lib/blob/master/cordova-common/=
src/ConfigChanges/ConfigChanges.js#L91
> [3] https://github.com/MSOpenTech/cordova-lib/blob/master/cordova-common/=
src/ConfigChanges/ConfigKeeper.js#L47
>
> [4] https://github.com/MSOpenTech/cordova-lib/commit/699bfe44a917b264815d=
c99efa0d770b766fa3a9
>
> -
> Best regards, Vladimir
>
> From: Vladimir Kotikov (Akvelon)
> Sent: Friday, October 2, 2015 6:04 PM
> To: dev@cordova.apache.org
> Subject: Question about ios non-custom frameworks
>
> Hi, guys. I=E2=80=99m looking into the tests failures on OS X, caused by =
PlatformApi refactoring and it seems they caused by double caching of ios p=
bxproj files: first time in ios_parser [1] and second time in PlatformMunge=
r (through ConfigFile class) [2], [3]. It seems that at some time one file =
get cached twice and then saving one cached instance we=E2=80=99re overwrit=
ing changes, saved from another cache.
>
> [1] https://github.com/MSOpenTech/cordova-lib/blob/master/cordova-lib/src=
/plugman/platforms/ios.js#L210

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org