Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: alsorokin <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-332-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-332-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-9872 Fixed save.spec.11 failure
Content-Type: text/plain
Message-Id: <20151028222948.84A8CDFBAB@git1-us-west.apache.org>
Date: Wed, 28 Oct 2015 22:29:48 +0000 (UTC)

Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/332#discussion_r43327317
  
    --- Diff: cordova-lib/spec-cordova/save.spec.js ---
    @@ -244,19 +307,26 @@ describe('(save flag)', function () {
                     console.log(err);
                     expect(false).toBe(true);
                     done();
    +            }).finally(function () {
    +                revertDownloadPlatform();
                 });
    -        }, timeout);
    +        }, TIMEOUT);
     
             it('spec.11 should update spec with git url when updating using git url', function (done) {
                 helpers.setEngineSpec(appPath, platformName, platformVersionNew);
    -            platform('add', platformName + '@' + platformVersionNew)
    +            mockDownloadPlatform(platformLocalPathOld, platformVersionOld);
    +
    +            platform('add', platformName + '@' + platformVersionOld)
                 .then(function () {
    +                revertDownloadPlatform();
                     var fsExistsSync = fs.existsSync.bind(fs);
                     spyOn(fs, 'existsSync').andCallFake(function (somePath) {
                         return (somePath === path.join(appPath, 'platforms', platformName)) || fsExistsSync(somePath);
                     });
    +                mockDownloadPlatform(platformLocalPathNew, platformVersionNew);
    --- End diff --
    
    I believe I'll be able to catch platform update issues running my usual manual test cases which I do on every platform release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org