Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-327-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-327-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: On Windows,
 verify browsers installed be...
Content-Type: text/plain
Message-Id: <20151020221212.CE7E6DFE2E@git1-us-west.apache.org>
Date: Tue, 20 Oct 2015 22:12:12 +0000 (UTC)

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/327#discussion_r42561832
  
    --- Diff: cordova-serve/src/browser.js ---
    @@ -72,7 +79,10 @@ module.exports = function (opts) {
                 args.push(url);
             }
             var command = args.join(' ');
    -        return exec(command);
    +        return exec(command).catch(function (error) {
    +            // Assume any error means that the browser is not installed and display that as a more friendly error.
    +            throw new Error(NOT_INSALLED.replace('%target%', target));
    --- End diff --
    
    typo again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org