Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-80-cordova-plugin-contacts@git.apache.org>
In-Reply-To: <git-pr-80-cordova-plugin-contacts@git.apache.org>
Subject: [GitHub] cordova-plugin-contacts pull request: Solving memory leak
 issues d...
Content-Type: text/plain
Message-Id: <20151019140255.2DF27E0419@git1-us-west.apache.org>
Date: Mon, 19 Oct 2015 14:02:55 +0000 (UTC)

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/80#discussion_r42373906
  
    --- Diff: src/android/ContactAccessorSdk5.java ---
    @@ -283,6 +283,10 @@ public JSONArray search(JSONArray fields, JSONObject options) {
                     ContactsContract.Data.CONTACT_ID + " ASC");
              
             JSONArray contacts = populateContactArray(limit, populate, c);
    +        
    +        if (!c.isClosed()) {
    +          c.close();
    --- End diff --
    
    Please correct indentation to use 4 spaces per one level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org