Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BEBC2181E9 for ; Mon, 19 Oct 2015 12:01:18 +0000 (UTC) Received: (qmail 77829 invoked by uid 500); 19 Oct 2015 12:01:18 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 77792 invoked by uid 500); 19 Oct 2015 12:01:18 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 77781 invoked by uid 99); 19 Oct 2015 12:01:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Oct 2015 12:01:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E3987E00CC; Mon, 19 Oct 2015 12:01:17 +0000 (UTC) From: daserge To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies Content-Type: text/plain Message-Id: <20151019120117.E3987E00CC@git1-us-west.apache.org> Date: Mon, 19 Oct 2015 12:01:17 +0000 (UTC) Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90#issuecomment-149195485 @mlaponder, @lvanengelen, thanks for your contribution! Is there a specific reason why you did not put the new flag to the end of the list? This way it would not be needed to change other platforms interface besides `wp8`. Is there an opportunity to add a test case for this? Do I get it right that the feature is an extension of [CB-8761 WP8: FileTransfer does not inherit cookies from WebBrowser](https://issues.apache.org/jira/browse/CB-8761) for cross-origin case, so that the test will require a host separate from [cordova-labs/file-transfer](https://github.com/apache/cordova-labs/tree/cordova-filetransfer) -> [cordova-vm.apache.org](https://github.com/apache/cordova-plugin-file-transfer/blob/c79ee367a108384cbe10b8bc8038911612a67bef/tests/tests.js#L42) test server? I propose you to refactor this in terms of not changing unrelated platforms (move `useBrowserHttp` to the end) and send a proposal to dev@cordova.apache.org (and optionally to https://github.com/cordova/cordova-discuss/issues/) so that the community can discuss whether to merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org