Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D24B5186F2 for ; Thu, 15 Oct 2015 22:54:55 +0000 (UTC) Received: (qmail 75743 invoked by uid 500); 15 Oct 2015 22:54:55 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 75703 invoked by uid 500); 15 Oct 2015 22:54:55 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 75692 invoked by uid 99); 15 Oct 2015 22:54:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2015 22:54:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 341E4E1119; Thu, 15 Oct 2015 22:54:55 +0000 (UTC) From: TimBarham To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand. Content-Type: text/plain Message-Id: <20151015225455.341E4E1119@git1-us-west.apache.org> Date: Thu, 15 Oct 2015 22:54:55 +0000 (UTC) Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/322#discussion_r42191593 --- Diff: cordova-lib/src/platforms/PlatformApiPoly.js --- @@ -566,7 +566,8 @@ PlatformApiPoly.prototype._addModulesInfo = function(plugin, targetDir) { var moduleName = plugin.id + '.' + ( moduleToInstall.name || moduleToInstall.src.match(/([^\/]+)\.js/)[1] ); var obj = { file: ['plugins', plugin.id, moduleToInstall.src].join('/'), - id: moduleName + id: moduleName, + plugin: plugin.id --- End diff -- `pluginId` perhaps? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org