Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: daserge <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-224-cordova-cli@git.apache.org>
In-Reply-To: <git-pr-224-cordova-cli@git.apache.org>
Subject: [GitHub] cordova-cli pull request: CB-9784 Remove CLI logger levels
 prefixe...
Content-Type: text/plain
Message-Id: <20151013064337.C514AE095C@git1-us-west.apache.org>
Date: Tue, 13 Oct 2015 06:43:37 +0000 (UTC)

Github user daserge commented on the pull request:

    https://github.com/apache/cordova-cli/pull/224#issuecomment-147620672
  
    > We should remove this: https://github.com/apache/cordova-cli/pull/224/files#diff-567859a4cc8b910de0454da79959bde6R53 - I know a lot of downstream tools currently use Error: prefix to determine something is an error vs not.
    
    It makes sense in terms of backwards compatibility - removed this trimming. 
    Although we will need to revert those code where we have removed the `Error: ` prefixes or alternatively concat such a prefix automatically in logger for `error` level if it is missing in an event message.
    
    In this case we will still have an excess noise but it should be acceptable as error messages are uncommon.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org