Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-226-cordova-android@git.apache.org>
In-Reply-To: <git-pr-226-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: CB-9782 Implements PlatformApi
 contr...
Content-Type: text/plain
Message-Id: <20151013003555.5D08EE0451@git1-us-west.apache.org>
Date: Tue, 13 Oct 2015 00:35:55 +0000 (UTC)

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/226#discussion_r41816386
  
    --- Diff: bin/templates/cordova/Api.js ---
    @@ -0,0 +1,506 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +var Q = require('q');
    +var fs = require('fs');
    +var path = require('path');
    +var shell = require('shelljs');
    +
    +var CordovaError = require('cordova-common').CordovaError;
    +var PlatformJson = require('cordova-common').PlatformJson;
    +var ActionStack = require('cordova-common').ActionStack;
    +var AndroidProject = require('./lib/AndroidProject');
    +var PlatformMunger = require('cordova-common').ConfigChanges.PlatformMunger;
    +var PluginInfoProvider = require('cordova-common').PluginInfoProvider;
    +
    +var pluginHandlers = require('./lib/pluginHandlers');
    +
    +var PLATFORM = 'android';
    +var GENERIC_EVENTS = new (require('events').EventEmitter)()
    +    .on('verbose', function (message) {
    +        if (process.argv.indexOf('-d') >= 0 || process.argv.indexOf('--verbose') >= 0)
    +            console.log(message);
    +    })
    +    .on('log', console.log)
    +    .on('warn', console.warn)
    +    .on('error', function (error) {
    +        if (process.argv.indexOf('-d') >= 0 || process.argv.indexOf('--verbose') >= 0) {
    +            console.error((error && error.message) || error);
    --- End diff --
    
    Should this be flipped? We should `stack` for verbose output and not otherwise? Also, does the message not show when we show stack? If I understand correctly, this is only for legacy scenarios - correct? Otherwise, the cli should eventually be doing the logging - correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org