Return-Path: 
 <dev-return-50777-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AFBE518065
	for <apmail-cordova-dev-archive@www.apache.org>;
 Mon,  5 Oct 2015 21:19:14 +0000 (UTC)
Received: (qmail 80272 invoked by uid 500); 5 Oct 2015 21:19:14 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 80230 invoked by uid 500); 5 Oct 2015 21:19:14 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 80219 invoked by uid 99); 5 Oct 2015 21:19:13 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Oct 2015 21:19:13 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 893D0E03CE; Mon,  5 Oct 2015 21:19:13 +0000 (UTC)
From: shazron <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-312-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-312-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-9569 - Support <access> and
 <allow-na...
Content-Type: text/plain
Message-Id: <20151005211913.893D0E03CE@git1-us-west.apache.org>
Date: Mon,  5 Oct 2015 21:19:13 +0000 (UTC)

Github user shazron commented on the pull request:

    https://github.com/apache/cordova-lib/pull/312#issuecomment-145671308
  
    Hmm one problem that I can see is, this assumes the last item to "clobber" the ATS entry is the last one standing. There is no merge strategy. For example:
    ```
    <access origin="https://*.google.com />
    <access origin="https://google.com />
    ```
    
    We would only pick up the last item there, were subdomains are *not* allowed. We can't possibly decipher the intent of the user here, it is up to the user to write a coherent whitelist policy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org