cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-4596 Documentation is ...
Date Wed, 28 Oct 2015 00:33:24 GMT
GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/55

    CB-4596 Documentation is not consistent for timestamp types

    Treats all timestamp objects as DOMTimeStamp objects which are ever increasing msecs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-plugin-geolocation CB-4596

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit cbdcedf056bbe8ee932b8542582520f6a3b4eca5
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2015-10-27T23:45:07Z

    CB-4596 Date objects are supposed to be DOMTimeStamp (s)

commit 163051aa38547eb09eef65b9f5267db1bc8c375f
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2015-10-27T23:51:53Z

    Fixed lint errors.

commit bf8a373418f3056da93c85f957d91197f51db18a
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2015-10-28T00:28:50Z

    Expect lastPosition to have a timestamp that is already in msecs (DOMTimeStamp)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message