cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pke <...@git.apache.org>
Subject [GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
Date Tue, 27 Oct 2015 11:38:21 GMT
GitHub user pke opened a pull request:

    https://github.com/apache/cordova-plugin-device/pull/42

    Feature add is simulator for windows

    This adds the `isVirtual` for the Windows 8.x Desktop and Phone platforms.
    Virtual means the app is running in the Windows Simulator (a remote session) or the Windows
Phone/Mobile Emulator.
    
    I also simplified the retrieval of the device manufacture name by using ?`` `Windows.Security.ExchangeActiveSyncProvisioning.EasClientDeviceInformation`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pke/cordova-plugin-device feature-add-is-simulator-for-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit 05787ac65b71988b360c367521c82897f006fe40
Author: Philipp Kursawe <phil.kursawe@gmail.com>
Date:   2015-10-27T11:34:24Z

    Add `isVirtual` for Windows 8.x (Phone) platforms
    
    Sets `isVirtual` to true when:
    - Running in Simulator on Windows 8.x/10
    - Running in Windows Phone 8.x Emulator
    
    This also uses the `Windows.Security.ExchangeActiveSyncProvisioning.EasClientDeviceInformation`
to get the manufacturer instead of querying this from the PnP devices.
    
    Not tested with Windows 10 Mobile Emulator, but should be the same as Windows 8.1 Phone.

commit d695f7dfef2689d1caa5f4796a0aea1339b3e2ee
Author: Philipp Kursawe <phil.kursawe@gmail.com>
Date:   2015-10-27T11:34:44Z

    fix whitespace tab to spaces

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message