cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pstoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-network-information pull request: Fix checks that a...
Date Mon, 05 Oct 2015 15:31:56 GMT
GitHub user pstoll opened a pull request:

    https://github.com/apache/cordova-plugin-network-information/pull/35

    Fix checks that always evaluate to true.

    The compiler in Xcode [Version 7.0 (7A220)] warned on these lines that they always evaluate
to true. Sure enough, taking the address of an object is always non-null. Fix this to test
that these objects are non-null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pstoll/cordova-plugin-network-information CB-9702

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-network-information/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 5aac2609ceafcdcb0a746dd54bb21899a2f90a7a
Author: Perry Stoll <perry@pstoll.com>
Date:   2015-10-05T14:51:02Z

    These notifications are objects so their address always evaluates to true.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message