cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EddyVerbruggen <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...
Date Sat, 24 Oct 2015 06:48:45 GMT
GitHub user EddyVerbruggen opened a pull request:

    https://github.com/apache/cordova-ios/pull/174

    CB-9685 Enhanced the fix for the iOS9 longpress magnifying glass issue

    This feature is now disabled by default and can be enabled for longpress in `config.xml`:
    `<preference name="SuppressesLongPressGesture" value="true" />`
    
    When 3D Touching the webview (apply pressure during your touch) the magnification glass
will also pop up. It won't even wait for a longpress in this case. To disable this issue as
well, add this to `config.xml`:
    `<preference name="Suppresses3DTouchGesture" value="true" />`
    
    Note that if the former is true, the latter is ignored since they essentially use the
same gesture `UILongPressGestureRecognizer` (which is a shame but that's how Apple implemented
it). The other way around works fine, so to have the behavior of the previous version of this
plugin, you'd do:
    
    ```xml
        <preference name="SuppressesLongPressGesture" value="true" />
        <preference name="Suppresses3DTouchGesture" value="false" />
    ```
    
    Omitting the properties is the same as setting both to`false`.
    
    The reason for having the developer explictly enabling these features is that disabling
longpress may break text selection (most relevantly in input fields).
    The reason there's a sep property for 3D Touch is it will break onclick handlers, but
ontouchend works just fine, so it really depends on your app/framework if it's a workable
fix.
    
    Please merge this so I can sleep better at night.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EddyVerbruggen/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
    
----
commit b6348f7a0cb55ca3972334cb40ad310823792fa9
Author: EddyVerbruggen <eddyverbruggen@gmail.com>
Date:   2015-09-22T10:02:36Z

    CB-9685 A fix for the magnifying glass popping up on iOS9 when longpressing the webview

commit 842997cba173ca90bd5e4f1943653533be69942b
Author: EddyVerbruggen <eddyverbruggen@gmail.com>
Date:   2015-10-24T05:58:58Z

    Merge remote-tracking branch 'upstream/master'

commit 371c136315b0c4f481ee479242dd769c4280b932
Author: EddyVerbruggen <eddyverbruggen@gmail.com>
Date:   2015-10-24T06:41:07Z

    CB-9685 A fix for the magnifying glass popping up on iOS9 when longpressing the webview.
This is now disabled by default and can be enabled for longpress in config.xml:
        <preference name="SuppressesLongPressGesture" value="true" />
     and also for 3D Touch:
        <preference name="Suppresses3DTouchGesture" value="true" />
     note that if the former is true, the latter is ignored

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message