cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mardy <...@git.apache.org>
Subject [GitHub] cordova-ubuntu pull request: build: fix mechanism for additional d...
Date Fri, 09 Oct 2015 13:50:06 GMT
GitHub user mardy opened a pull request:

    https://github.com/apache/cordova-ubuntu/pull/15

    build: fix mechanism for additional dependencies

    Instead of expecting plugins to store their configuration files in
    a "configs/" directory, read the dependencies from the config.xml file.
    The reason why the old method does not work is that the `<resource-file>`
    element of the `plugin.xml` file doesn't support a "target-dir" attribute.
    
    By using the `<config-file>` element, instead, we don't need to do any
    changes to cordova lib, and all the plugin configuration can now be
    stored in the `plugin.xml` file.
    
    Example:
    ```xml
    <config-file target="config.xml" parent="/*">
      <feature name="FacebookConnect">
        <param policy_group="accounts" policy_version="1" />
        <param hook="account-application" value="qml/app.application" />
        <param hook="account-service" value="qml/app.service" />
        <deps>
          <pkgConfig>["signond", "libsignon-qt5"]</pkgConfig>
          <deb>["signond-dev:ARCH", "libsignon-qt5-dev:ARCH"]</deb>
        </deps>
      </feature>
    </config-file>
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu 5.3.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ubuntu/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
Author: Alberto Mardegan <mardy@users.sourceforge.net>
Date:   2015-10-08T06:36:31Z

    build: fix mechanism for additional dependencies
    
    Instead of expecting plugins to store their configuration files in
    a "configs/" directory, read the dependencies from the config.xml file.
    The reason why the old method does not work is that the <resource-file>
    element of the plugin.xml file doesn't support a "target-dir" attribute.
    
    By using the <config-file> element, instead, we don't need to do any
    changes to cordova lib, and all the plugin configuration can now be
    stored in the plugin.xml file.
    
    Example:
    
    <config-file target="config.xml" parent="/*">
      <feature name="FacebookConnect">
        <param policy_group="accounts" policy_version="1" />
        <param hook="account-application" value="qml/app.application" />
        <param hook="account-service" value="qml/app.service" />
        <deps>
          <pkgConfig>["signond", "libsignon-qt5"]</pkgConfig>
          <deb>["signond-dev:ARCH", "libsignon-qt5-dev:ARCH"]</deb>
        </deps>
      </feature>
    </config-file>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message