cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pke <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: remove publisherId since its overrid...
Date Fri, 23 Oct 2015 21:59:27 GMT
GitHub user pke opened a pull request:

    https://github.com/apache/cordova-windows/pull/127

    remove publisherId since its overridden by the certficate during build

    1. The publisherId set here is __always__ overridden by the `CN` from the projects associated
certificate. That is by default, the Cordova certificate that has `CN=The Cordova Team`. Therefor
the resulting `AppxManifest.xml` will always have `Publisher="CN=The Cordova Team"` set regardless
of what one puts into `publisherId`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pke/cordova-windows patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 62c7eb1eab1eeb0e47ee8f3c8dbeaae7cd26e6bb
Author: Philipp Kursawe <phil.kursawe@gmail.com>
Date:   2015-10-23T21:58:46Z

    remove publisherId since its overridden by the certficate during build
    
    1. The publisherId set here is __always__ overridden by the `CN` from the projects associated
certificate. That is by default, the Cordova certificate that has `CN=The Cordova Team`. Therefor
the resulting `AppxManifest.xml` will always have `Publisher="CN=The Cordova Team"` set regardless
of what one puts into `publisherId`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message