cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbektchiev <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings
Date Tue, 27 Oct 2015 08:03:59 GMT
GitHub user mbektchiev opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/120

    Fix lint warnings

    The latest Android build tools output the following errors when building a project containing
the InAppBrowser plugin in release configuration:
    
    ```
    :lintVitalRelease
    /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:555:
Error: Expected resource of type id [ResourceType]
                    actionButtonContainer.setId(1);
                                                ~
    /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:563:
Error: Expected resource of type id [ResourceType]
                    back.setId(2);
                               ~
    /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:587:
Error: Expected resource of type id [ResourceType]
                    forward.setId(3);
                                  ~
    /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:610:
Error: Expected resource of type id [ResourceType]
                    edittext.setId(4);
                                   ~
    /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:633:
Error: Expected resource of type id [ResourceType]
                    close.setId(5);
                                ~
    /tmp/builds/pD4TvwB54LApFFdtTl/app/src/org/apache/cordova/inappbrowser/InAppBrowser.java:679:
Error: Expected resource of type id [ResourceType]
                    inAppWebView.setId(6);
                                       ~
    
       Explanation for issues of type "ResourceType":
       Ensures that resource id's passed to APIs are of the right type; for
       example, calling Resources.getColor(R.string.name) is wrong.
    
    6 errors, 0 warnings
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Icenium/cordova-plugin-inappbrowser bektchiev/fix-lint-errors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #120
    
----
commit b9fd644401f2a7744b37cddb4465b84ad782f929
Author: Martin Bektchiev <martin.bektchiev@telerik.com>
Date:   2015-10-27T07:58:12Z

    Fix lint warnings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message