cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: Merging latest pull requests into Master today
Date Mon, 05 Oct 2015 17:32:35 GMT
I was screwing up the scope, sorry.

We should be initializing it with the permissions in the constructor.  The
purpose of it is for the Java API.  So, if we have a plugin dependency that
needs to access the permissions of the parent plugin somehow, they can just
request the permissions instead of cueing every permission individually.

On Mon, Oct 5, 2015 at 10:26 AM, Nikhil Khandelwal <nikhilkh@microsoft.com>
wrote:

> Sorry for not responding earlier. I like where this is going. I have a
> bunch of comments on the PRs.
>
> I have some confusion around how CordovaPlugin has a protected field
> 'permissions' and what a derived CordovaPlugin is supposed to do with it.
> None of our core plugins seem to use it.
>
> Thanks,
> Nikhil
>
> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Monday, October 5, 2015 9:05 AM
> To: dev <dev@cordova.apache.org>
> Subject: Merging latest pull requests into Master today
>
> Hey
>
> I'm going to pull the 5.0.x proposed pull requests into Master today.  Can
> anyone take a look at them before I do this.  I'm going to wait until after
> 1 PM to do it, so if you can check out the new pull requests and comment
> on them before then, that would be greatly appreciated, otherwise I'm going
> to assume all is good and merge them into the master.
>
> You've been warned. ;)
>
> Joe
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message