cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Santana <csantan...@gmail.com>
Subject Re: CB-9739 Prevent coho from creating broken packages including CRLF on Windows
Date Fri, 02 Oct 2015 13:27:19 GMT
this is good, I made comments on the PR
Yes agree also to .gitattributes one more thing for contributors to worry
about.

On Fri, Oct 2, 2015 at 8:36 AM Sergey Shakhnazarov (Akvelon) <
v-seshak@microsoft.com> wrote:

> Hello guys,
>
> Please review the PR[1], which prevents coho from creating broken packages
> including CRLF on Windows.
> This is related to previous release issue[2].
>
> I wanted to discuss whether we need to also add .gitattributes to the
> repos with
> * text eol=lf
> to force line endings to be LF internally (in case a dev has checked in
> CRLF eols).
>
> [1]: https://github.com/apache/cordova-coho/pull/95
> [2]: http://markmail.org/message/gejy6mgjfsqymi75
>
> Best regards,
> Sergey Shakhnazarov
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message