cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julio cesar sanchez <jcesarmob...@gmail.com>
Subject Re: [GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...
Date Thu, 22 Oct 2015 11:08:21 GMT
Ok, forget about the -webkit-user-select: none; part, you might put that on
the body but use -webkit-user-select: text; on input type text and textarea.

2015-10-22 13:03 GMT+02:00 julio cesar sanchez <jcesarmobile@gmail.com>:

> +1 for preference
>
> but I think the problem the plugin solves only appears when you add the
> css to avoid text selection (-webkit-user-select: none;), so if the user
> wants text selection he won't add that css and he doesn't need the plugin.
>
> BTW, I'm not able to reproduce the magnifier glass issue on iOS 9.1, maybe
> apple fixed it?
>
>
> 2015-10-22 12:18 GMT+02:00 EddyVerbruggen <git@git.apache.org>:
>
>> Github user EddyVerbruggen commented on the pull request:
>>
>>     https://github.com/apache/cordova-ios/pull/164#issuecomment-150170110
>>
>>     I think I'll be adding a configuration for this to config.xml as not
>> all folks may like this feature (new PR).
>>
>>     The plugin that inspired this PR has been around for a few weeks now:
>> https://github.com/EddyVerbruggen/cordova-plugin-ios-longpress-fix and
>> while most like it, it may break text selection. If your app needs that
>> this feature will cause trouble.
>>
>>     I propose enabling this private plugin only when a certain config.xml
>> property has been enabled.
>>
>>     And I'd also like to add a feature to suppress the magnifying glass
>> for devices with 3D Touch support. In the plugin mentioned above I've
>> already done so, by specifying a preference: `<preference
>> name="Suppress3DTouch" value="true" />`.
>>
>>     Any thoughts others want to share perhaps?
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message