cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikhil Khandelwal <>
Subject RE: Merging smores branch into Cordova-Android TODAY
Date Mon, 19 Oct 2015 01:28:08 GMT
Thanks Joe! 

Most of the changes look good. I did leave a comment on the design of the CordovaPlugin base
class - I don’t want to block progress on that. Feel free to merge it - but let's see if
we can rationalize why we are adding the base class methods - it seems only for the Geoloc
plugin - but I don’t know enough about this area to understand this fully.

I would love to see the guidance for what changes a plugin developer should make to work in
Marshmallow - Perhaps even giving them a link to our commit to fix one of the plugins.


-----Original Message-----
From: Joe Bowser [] 
Sent: Friday, October 16, 2015 2:33 PM
To: dev <>
Subject: Re: Merging smores branch into Cordova-Android TODAY

I guess that I'm going to have to write the blog post for this release, including how permissions
work on Android.

On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N <>

> As discussed in the Cordova Face to Face yesterday, we said that we 
> want our users to be aware of changes like these that will hit them. 
> Is someone looking at writing a blog post for this ?
> -----Original Message-----
> From: Joe Bowser []
> Sent: Friday, October 16, 2015 10:35 AM
> To: dev <>
> Subject: Merging smores branch into Cordova-Android TODAY
> Hey
> I'm going to be merging the smores branch into master by 3:00 PM today.
> I've left this pull request open for the past week, so we should be 
> ready to go.  Please let me know if there's any reason I shouldn't 
> merge this in.  Once this is merged, there will be a discuss thread 
> for Cordova-Android 5.0.0.
> If you have a Nexus device, please update it to Marshmallow and start 
> testing Cordova applications and filing those issues in our JIRA.  If 
> there's third party plugins, please let me know, and I will look at 
> them and see if there's any major issues with that plugin being 
> upgraded and will try to contact the author.
> If we can be a bit more pro-active with this one to try and avoid 
> breakage (there shouldn't be much breakage, since most plugins don't 
> ask for more permissions), that would be awesome.
> Thanks
> Joe
View raw message